This is the mail archive of the cygwin@sources.redhat.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] default homedir (was: Re: Problem with ssh-keygen.exe.


At 11:31 12/6/00 +0100, Corinna Vinschen wrote:
>I have a major problem with your patch. I can't apply it since you
>seem to have attached it to your mail using copy-paste. The indenting
>is broken and it contains unmotivated line breaks so patch doesn't
>accept this as input.

there are days I hate my mail client... then there are the days
I loathe it. This *should* be corrected this time.

>    if (strlen(foo) == 0)

It's habit forming to do it the otherway, I'll make a mental
note to use the dangerous form for cygwin patches.

> > -                                                name);
> > +                         passed_home_path, name);
>
>The latter looks a bit strange. Did you use tabs of four chars or the
>like?

yuck, actually that seems to have been my editor, it wanted to
align under the opening '(', I've used the same spacing as the
preceding line now, which is not the same as the following line.

I just pulled a clean copy from cvs to patch, and reconfigured
my editor for 1 tab = 8 spaces, I also set it to render tabs,
this file is very inconsistent in which it uses for indents,
which might be why my editor got confused, I know I did at
first, until I moved up to 8 spaces.

now the forces of openness
     have a powerful and
     unexpected new ally
    http://ibm.com/linux/

patch

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]