This is the mail archive of the
cygwin@sourceware.cygnus.com
mailing list for the Cygwin project.
Re: nasty bug in bsearch() in b17.1 under Windows'95????
- To: Jim Balter <jqb at netcom dot com>
- Subject: Re: nasty bug in bsearch() in b17.1 under Windows'95????
- From: Mumit Khan <khan at xraylith dot wisc dot edu>
- Date: Tue, 25 Mar 1997 22:54:24 -0600
- Cc: gnu-win32 at cygnus dot com
Jim Balter <jqb@netcom.com> writes:
>
> The bsearch.c in newlib contains a quite explicit and quite erroneous
> comparison to the item one past the last range whenever the key isn't
> found. Normally this is merely pointless extra work, but if the key is
> greater than the last element, then it is an out of bounds reference,
> just as you have discovered. The "easiest" fix is to simply remove the
> lines
>
> if (compar (key, base) == 0)
> return (_PTR) base;
>
Exactly. Just looked at the source, and it's quite obvious. As you
mention, it also does an extra comparison for no reason whatsoever
in the other cases.
Here's the trivial patch, which took non-trivial number of hours
to find ;-) debugging f771 on a '95 box is no fun.
*** bsearch.c.~1 Tue Mar 25 22:47:42 1997
--- bsearch.c Tue Mar 25 22:47:46 1997
*************** _DEFUN (bsearch, (key, base, nmemb, size
*** 94,100 ****
}
- if (compar (key, base) == 0)
- return (_PTR) base;
-
return NULL;
}
--- 94,97 ----
Regards,
Mumit -- khan@xraylith.wisc.edu
http://www.xraylith.wisc.edu/~khan/
-
For help on using this list, send a message to
"gnu-win32-request@cygnus.com" with one line of text: "help".