This is the mail archive of the cygwin-xfree mailing list for the Cygwin XFree86 project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix mwextwm mode to build again

Yaakov (Cygwin/X) wrote:
Hash: SHA256

Jon TURNEY wrote:
This fixes multiwindow external window manager('-mwextwm') mode to build

Note this depends on Apple's Xplugin.h to build the rootless extension
(just for some typedefs I think), which is no longer included in the
X.Org tree, as an old version once was.

Thank you Jon and Colin for the patch. A few questions:

1) The ROOTLESS_WORKAROUND define only affects one place, namely
miext/damage/damage.c:getDrawableDamageRef().  What does this do
exactly, and what affect may it have on modes other than -mwextwm?

$ git blame miext/damage/damage.c -L /ROOTLESS/,+3
d7fef522 (Kevin E Martin 2004-09-02 04:04:47 +0000 93) #ifdef ROOTLESS_WORKAROUND
b2135e58 (Kevin E Martin 2004-09-03 16:18:23 +0000 94) && ((WindowPtr)pDrawable)->viewable
d7fef522 (Kevin E Martin 2004-09-02 04:04:47 +0000 95) #endif

$ git log -1 d7fef522
commit d7fef52254126aa5897a5c58faeda1f61d5b13d8
Author: Kevin E Martin <>
Date:   Thu Sep 2 04:04:47 2004 +0000

    Workaround for servers using rootless layer with damage (Bug #1168, Torrey
        T. Lyons).

$ git log -1 b2135e58
commit b2135e589baeb2ea26da50b9167feaea23bcce3c
Author: Kevin E Martin <>
Date:   Fri Sep 3 16:18:23 2004 +0000

    First set of documentation updates.
    Include more correct fix for rootless interaction with damage (Bug #1168,
        Keith Packard).

2) Why delete the RootlessAccelInit call in

As I recall, that code has been disabled in the 1.5.x tree, so we can't call it. I think I noticed that it's recently been turned back on by the Apple guys in git master.

-- Unsubscribe info: Problem reports: Documentation: FAQ:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]