Re: [PATCH v2 1/4] Cygwin: console: Add workaround for broken IL/DL in xterm mode.

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

[CC Hans]

On Feb 28 11:14, Takashi Yano wrote:
> On Thu, 27 Feb 2020 18:03:47 +0000
> Jon Turney wrote:
> > > +#define wpbuf_put(x) \
> > > +  wpbuf[wpixput++] = x; \
> > > +  if (wpixput > WPBUF_LEN) \
> > > +    wpixput--;
> > > +
> > 
> > So I think either the macro need it contents contained by a 'do { ... } 
> > while(0)',  or that instance of it needs to be surrounded by braces, to 
> > do what you intend.
> 
> Thanks for the advice. Fortunately, "if" statement does not
> cause a problem even if it is accidentally executed outside
> "else" block in this case.
> 
> Hans,
> as for making a patch for this issue, may I leave it to you
> because you are already working on it? 
> 
> -- 
> Takashi Yano <takashi.yano@nifty.ne.jp>

-- 
Corinna Vinschen
Cygwin Maintainer

Attachment: signature.asc
Description: PGP signature