Re: [PATCH] Cygwin: pty: Add missing console API hooks.

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

Hi Takashi,

On Jan 23 22:05, Takashi Yano wrote:
> On Thu, 23 Jan 2020 13:48:13 +0100
> Corinna Vinschen wrote:
> > On Jan 23 13:33, Takashi Yano wrote:
> > > - Following console APIs are additionally hooked for cygwin programs
> > >   which directly call them.
> > >   * FillConsoleOutputAttribute()
> > >   * FillConsoleOutputCharacterA()
> > >   * FillConsoleOutputCharacterW()
> > >   * ScrollConsoleScreenBufferA()
> > >   * ScrollConsoleScreenBufferW()
> > 
> > Which Cygwin programs are doing that?  They wouldn't work correctly in
> > ptys anyway, isn't it?  Does it really make sense to make them happy
> > rather than requesting to change them?
> 
> Just a possibility. There is no specific example.

In that case I'd prefer not to apply this patch.  Using native Windows
console functions in a Cygwin application just doesn't make sense, and
we shouldn't support that beyond what's necessary for older, existing
applications.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

Attachment: signature.asc
Description: PGP signature