This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.
- From: Ken Brown <kbrown at cornell dot edu>
- To: "cygwin-patches at cygwin dot com" <cygwin-patches at cygwin dot com>
- Cc: Jari Aalto <jari dot aalto at cante dot net>
- Date: Mon, 20 Jan 2020 14:58:52 +0000
- Subject: Re: [PATCH] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wBshCEfIoobMmSjW77RBb7vyQPWO+RK+qBZykRp3E4Y=; b=JXfQYdTIZvKMIoFwybyHQmbsi6JjQLaIupV0ioFQphAsZD/IgIIu34mes9fDYXUXnfFBpu2BWfEZj7q3dtKzsNdMsN3rEAOJz2gFUqpGILYqa09GC0BrC9PGhpf17keFzuJfbNhoAVQOb/DkTTxSOEUawtG2V6ANVGGhjStDRkShn7o/pNLW73EtN6ExHPuYUGBQmNWYew9Zf+IrA2gd2WzcTlpEG22XTL59ApPuzIVcpYOwZQfA5KXrh6ALAAx2jvYjUcDyhwT3+ddxClYoZPDIB05gCvKYpFSt9Ko62/SRKyPhsFyzLxZytPphxla0w7uCCgyVjiZ5g2G+rOMuoQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IBYNN7SxaP2zlQtmDCfa2vO5/M2egJXmZ6vLk4A8Rs3Wbo5KoqJt+6llRHt7+tZAwtFbbFLbm5ic6J2+mWLzxJwXx8+ZxDMKtWUiGcztSMo/66VX9I+tgWjl0cvLQZel/SOX6paDTFfBVFphs1GdtaQPtzYj5LO+JRl3qqmABPj3Spz3XVn8xUPAm2HMHrIQ6yeMX+intubc1JT2YQXnSQmjJtchSkUaAJAlOmCN/DT3on6Aqa0/5U2S8NVn++Oex922q7YZ653W3jwp2qot/LQl4UBW6+uoG7T0MBEp0z6LufhY176Kn/yDONA87ybs0FRTA60G5ma6XvDq1FJmNQ==
- References: <20200120025015.1520-1-takashi.yano@nifty.ne.jp> <20200120100646.GE20672@calimero.vinschen.de> <20200120214124.9da79990b75a658016cf34d7@nifty.ne.jp> <ed59eb98-8e59-f0d1-d1c3-9f44cb6cbee7@dronecode.org.uk>
[Adding the cgdb maintainer to the CC.]
On 1/20/2020 9:18 AM, Jon Turney wrote:
> On 20/01/2020 12:41, Takashi Yano wrote:
>> Hi Corinna,
>>
>> On Mon, 20 Jan 2020 11:06:46 +0100
>> Corinna Vinschen wrote:
>>> On Jan 20 11:50, Takashi Yano wrote:
>>>> - For programs which does not work properly with pseudo console,
>>>> disable_pcon in environment CYGWIN is introduced. If disable_pcon
>>>> is set, pseudo console support is disabled.
>>> Oh well, do we really need that?
>>
>> This is, for example, needed to solve the issue reported in
>> https://www.cygwin.com/ml/cygwin/2020-01/msg00147.html.
>>
>> I looked into this problem, and found that cgdb read output of
>> gdb from pty master and write it to ncurses. The output from
>> pty master includes a lot of escape sequences which are generated
>> by pseudo console, however, ncurses does not pass-through them
>> and shows garbages. This is the cause of that issue.
>>
>> cgdb is the only program do such things so far, however, there
>> may be more programs which do not expect escape sequences read
>> from pty.
>>
>> There is no way to control pseudo console not to generate
>> escape sequences, therefore, I proposed this patch.
>>
>
> I think this may actually be an issue with cgdb being old.
>
> The latest gdb enables "output styling" using ANSI escape sequences by default,
> but our cgdb can't handle them?
>
> See: https://github.com/cgdb/cgdb/issues/211