Re: [PATCH] Cygwin: select: Speed up select() call for pty, pipe and fifo.

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Jan 13 22:17, Marco Atzeri wrote:
> Am 13.01.2020 um 17:33 schrieb Corinna Vinschen:
> > On Jan  6 23:38, Takashi Yano wrote:
> > > - The slowing down issue of X11 forwarding using ssh -Y, reported
> > >    in https://www.cygwin.com/ml/cygwin/2019-12/msg00295.html,
> > >    is due to the change of select() code for pty in the commit
> > >    915fcd0ae8d83546ce135131cd25bf6795d97966. cygthread::detach()
> > >    takes at most about 10msec because Sleep() is used in the thread.
> > >    For this issue, this patch uses cygwait() instead of Sleep() and
> > >    introduces an event to abort the wait. For not only pty, but pipe
> > >    and fifo also have the same problem potentially, so this patch
> > >    applies same strategy to them as well.
> > 
> > Pushed.  And thanks for testing, Marco!
> > 
> > 
> > Thanks,
> > Corinna
> > 
> 
> you are welcome.
> 
> I found the improvement better than anything I ever seen
> on octave plotting with QT interface.
> Redrawing of the images when moving windows is now very responsive,
> in the past, also 3.0.x or before, the visual effect was poor.

Great, good to know!  In retrospect I wonder about these dumb
Sleep calls now replaced with cygwait, too...


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

Attachment: signature.asc
Description: PGP signature