This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Cygwin: console: Disable xterm mode for non cygwin process only.


Hi Takashi,

On Jan  1 15:51, Takashi Yano wrote:
> - Special function keys such as arrow keys or function keys do not
>   work in ConEmu with cygwin-connector after commit
>   6a06c6bc8f8492ea09aa3ae180fe94e4ac265611. This patch fixes the
>   issue.
> ---
> [...]
> diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
> index cea79e326..efd82c3c2 100644
> --- a/winsup/cygwin/spawn.cc
> +++ b/winsup/cygwin/spawn.cc
> @@ -29,6 +29,14 @@ details. */
>  #include "winf.h"
>  #include "ntdll.h"
>  
> +/* Not yet defined in Mingw-w64 */
> +#ifndef ENABLE_VIRTUAL_TERMINAL_PROCESSING
> +#define ENABLE_VIRTUAL_TERMINAL_PROCESSING 0x0004
> +#endif /* ENABLE_VIRTUAL_TERMINAL_PROCESSING */
> +#ifndef ENABLE_VIRTUAL_TERMINAL_INPUT
> +#define ENABLE_VIRTUAL_TERMINAL_INPUT 0x0200
> +#endif /* ENABLE_VIRTUAL_TERMINAL_INPUT */
> +

I think it's about time to move these definitions into a header, rather
than defining them in three different places.  winlean.h might be the
right place for them.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]