This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
[PATCH v2 3/3] Cygwin: fstatat: support the AT_EMPTY_PATH flag
- From: Ken Brown <kbrown at cornell dot edu>
- To: "cygwin-patches at cygwin dot com" <cygwin-patches at cygwin dot com>
- Date: Sun, 29 Dec 2019 17:56:58 +0000
- Subject: [PATCH v2 3/3] Cygwin: fstatat: support the AT_EMPTY_PATH flag
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tmgvrkxprk+Eu7QdHrNL6yLZ+zYd/vSTZ3l+y/4zyTU=; b=KxbUYqGDVGQWq6+QGMgdDuaWdDBlP25Fctu69wYcI4qp5DFcJ519ZX4n7B1p7ZuzM3SOzv3bNntBp1VdB8nWlNYANxMRblZp+1WVfevEjzusZc09zXbRaIhNNSe3bKkXBddGv2XShpjBqHJm8OZp8IwT9U6+G56gjkHYlGvjml33KpL3HrFtAeQp1JXE7eciljeAWiC5d5wMy7PQ7noBo+wVgc7/czjDSGc+NxBikZSTCrvPZrJuuAXbRlkHkdLT1hS2EXdV8eCcqRHkjujNeG8i3szewlmRKOCxJLvci+K4l9Q8E15F3Bq9VCT7UMqlsqzSy8Ftd+kSeg96dCTDHQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZNVNOl1RclhOYrmSbgnchUqCy/+APqahS6okTZT2U+WOrQgIUFmd5pnHssML9pOjIWcM4ukAoL8Bjc+Ys1xCdWIWxXGXHuUclLFOP5HzTjIluZUbr7I+KFwVovMIYPJLhUckmc+SmxBUs9nu11WnWNG1Bw4LpwPQoz0kMvZ4ByWWyjdbfOazdGZKcOlw53LhOtYQN8PYGEePfLp2D652tAtzagZvOGLpAoe141eMtHDsajESPnElYsBhx5HizZtbNF7d2RcLPo43G0Sfo2Rb3QuS2lziFNSjOSGKJLHADiVxkVrfVstbGB5MqlOKsc0ZdAFul0gUivC0//+BZGM0HA==
- References: <20191229175637.1050-1-kbrown@cornell.edu>
Following Linux, allow the pathname argument to be empty if the
AT_EMPTY_PATH is specified. In this case the dirfd argument can refer
to any type of file, not just a directory, and the call operates on
that file. In particular, dirfd can refer to a symlink that was
opened with O_PATH and O_NOFOLLOW.
---
winsup/cygwin/syscalls.cc | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc
index 2be8693c9..9b7d6dbfd 100644
--- a/winsup/cygwin/syscalls.cc
+++ b/winsup/cygwin/syscalls.cc
@@ -4808,14 +4808,27 @@ fstatat (int dirfd, const char *__restrict pathname, struct stat *__restrict st,
tmp_pathbuf tp;
__try
{
- if (flags & ~AT_SYMLINK_NOFOLLOW)
+ if (flags & ~(AT_SYMLINK_NOFOLLOW | AT_EMPTY_PATH))
{
set_errno (EINVAL);
__leave;
}
char *path = tp.c_get ();
- if (gen_full_path_at (path, dirfd, pathname))
- __leave;
+ int res = gen_full_path_at (path, dirfd, pathname);
+ if (res)
+ {
+ if (!(errno == ENOENT && (flags & AT_EMPTY_PATH)))
+ __leave;
+ /* pathname is an empty string. Operate on dirfd. */
+ if (dirfd == AT_FDCWD)
+ {
+ cwdstuff::cwd_lock.acquire ();
+ strcpy (path, cygheap->cwd.get_posix ());
+ cwdstuff::cwd_lock.release ();
+ }
+ else
+ return fstat (dirfd, st);
+ }
path_conv pc (path, ((flags & AT_SYMLINK_NOFOLLOW)
? PC_SYM_NOFOLLOW : PC_SYM_FOLLOW)
| PC_POSIX | PC_KEEP_HANDLE, stat_suffixes);
--
2.21.0