Re: [PATCH] Cygwin: console, pty: Prevent error in legacy console mode.

[Takashi Yano <takashi dot yano at nifty dot ne dot jp>]

Hi Corinna,

On Wed, 6 Nov 2019 15:05:47 +0100
Corinna Vinschen wrote:
> the patch is fine in general.  Still, what I really like to see is a
> descriptive log message, as well as a matching comment...
> 
> On Nov  6 20:59, Takashi Yano wrote:
> > @@ -3131,6 +3134,16 @@ fhandler_pty_master::setup_pseudoconsole ()
> >        if (res != S_OK)
> >  	system_printf ("CreatePseudoConsole() failed. %08x\n",
> >  		       GetLastError ());
> > +      error = true;
> > +    }
> > +
> 
> ...here, to explain briefly why this check is done.
> 
> > +  reg_key reg (HKEY_CURRENT_USER, KEY_READ, L"Console", NULL);
> > +  if (reg.error ())
> > +    error = true;
> > +  if (reg.get_dword (L"ForceV2", 1) == 0)
> > +    error = true;
> > +  if (error)
> > +    {
> >        CloseHandle (from_master);
> >        CloseHandle (to_slave);
> >        from_master = from_master_cyg;

I will submit revised version as v2 patch.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>