Re: [PATCH] Cygwin: Provide more COM devices

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

Hi Achim,

On Oct 20 15:27, Achim Gratz wrote:
> 
> This was requested on IRC.
> 
> >From a80b1c9ba67f94237948e85ad2dee744cdfbdcad Mon Sep 17 00:00:00 2001
> From: Achim Gratz <Stromeko@Stromeko.DE>
> Date: Sun, 20 Oct 2019 15:23:04 +0200
> Subject: [PATCH] Cygwin: provide more COM devices
> 
> * winsup/cygwin/devices.cc: Add another 64 COM devices since Windows
>   likes to create lots of these over time (one per identifiable device
>   and USB port).
> ---
>  winsup/cygwin/devices.cc | 64 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
> 
> diff --git a/winsup/cygwin/devices.cc b/winsup/cygwin/devices.cc
> index 2e31ca366..7a57459d8 100644
> --- a/winsup/cygwin/devices.cc
> +++ b/winsup/cygwin/devices.cc
> @@ -798,6 +798,70 @@ const _RDATA _device dev_storage[] =
>    {"/dev/ttyS61", BRACK(FHDEV(DEV_SERIAL_MAJOR, 61)), "\\??\\COM62", exists_ntdev, S_IFCHR, true},
> [...]

That's not the right way to patch this.  devices.cc gets generated from
devices.in by the gendevices script which in turn calls shilka from the
cocom package.  Apart from the struct members you added here, it will
also add some code.  Which, unfortunately, raise the size of devices.cc,
especially troubling the 32 bit version.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

Attachment: signature.asc
Description: PGP signature