This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, flags


Brian Inglis writes:
>> It would be easier to review if you would split it up into smaller patches, each 
>> doing one thing, to the extent that this makes sense.  For example, the 
>> simplification achieved by using the ftcprint macro could be done in a single 
>> patch that's separate from the substantive changes.
>
> Unfortunately, that was added later to make the got it/add it/skip it flag cross
> checks in Linux order more certain vs my own sequential tabular source.

I usually use Emacs/magit to split up a bunch of changes into a more
comprehensible series of commits post factum, but there are other ways
to achieve that same goal.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]