This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Cygwin: pty: Fix PTY so that cygwin setup shows help with -h option.
- From: Ken Brown <kbrown at cornell dot edu>
- To: "cygwin-patches at cygwin dot com" <cygwin-patches at cygwin dot com>
- Date: Thu, 26 Sep 2019 12:50:30 +0000
- Subject: Re: [PATCH] Cygwin: pty: Fix PTY so that cygwin setup shows help with -h option.
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z4+rhd4u2TSVfduNGYI/lYv+JTTNM/qvixwZVkQnIa4=; b=iUWps1u5AzFxPrb1yLToxRRNhaiebHy7dNnaw5gkLi51sFSOZ9W2iCKqYX/QaeeSdJ/NzJUuWMTR6JdvpD8JaUTrIBhPC/9ckUCyXXggidL/fEZX3HJ7D1lrNH9419sOvYVfkxz8CS9xykBmBx8uqmXVmPPw2acE7BGpdLzW03F0uaN0CSu27pq6KoVJyAzzFR20XMMCpr0RIr/s0am/1f0cuNVv4G+ASOZ6tTP8pyd1qyLkcNK6gTZe8O39pYR5S7dIfJ2AS0UKgOabp4v1bBJxFCebs0286SwyA6+yb0hNP+eZrqX+vVan0dg5tmGALAD3EmGr3JKMtuT3Mj/+fQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XlKD5OYJSuSkcw+BwUqUlP9PywOy1SIzYzzgdKO077hK0XqZBb6QI9CU+xuxjI/+YSSbw83k1aR0aA1DGbwZ3IKVCzIGKiy06x9KzGmUvg3djS6xqSq3otPIZfEAp4211vYXAcXPwO2MzjWf9bbxm7rHNjCqZF/KYKtI5reAsOfvt8No1KIzB9xe7zsLnoOMVK31qiRmQtSiMJXjV23kLUtKduhoId/Z51RoEw/ljoXvnlTMCqUtRxuUViMHAkLEaG3NfP2k4ZeHjl5QX/aJbVkmOVGrVkB+/xl/mQgC63bs01MniNuBx4K0slAr5kF6SIUJ1qJX1O4c5QgVdrx+Gg==
- References: <20190926105246.914-1-takashi.yano@nifty.ne.jp>
On 9/26/2019 6:52 AM, Takashi Yano wrote:
> - After commit 169d65a5774acc76ce3f3feeedcbae7405aa9b57, cygwin
> setup fails to show help message when -h option is specified, as
> reported in https://cygwin.com/ml/cygwin/2019-09/msg00248.html.
> This patch fixes the problem.
> ---
> winsup/cygwin/spawn.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
> index 4d8bcc9fa..f8090a6a4 100644
> --- a/winsup/cygwin/spawn.cc
> +++ b/winsup/cygwin/spawn.cc
> @@ -790,8 +790,6 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
> NtClose (old_winpid_hdl);
> real_path.get_wide_win32_path (myself->progname); // FIXME: race?
> sigproc_printf ("new process name %W", myself->progname);
> - if (!iscygwin ())
> - close_all_files ();
> }
> else
> {
> @@ -890,6 +888,8 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
> wait_for_myself ();
> }
> myself.exit (EXITCODE_NOSET);
> + if (!iscygwin ())
> + close_all_files ();
> break;
> case _P_WAIT:
> case _P_SYSTEM:
Pushed. Thanks.
Ken