This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Cygwin: console: Revive Win7 compatibility.
- From: Takashi Yano <takashi dot yano at nifty dot ne dot jp>
- To: cygwin-patches at cygwin dot com
- Date: Thu, 19 Sep 2019 05:50:15 +0900
- Subject: Re: [PATCH] Cygwin: console: Revive Win7 compatibility.
- Dkim-filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com x8IKoDcD028155
- References: <20190918142831.787-1-takashi.yano@nifty.ne.jp> <87pnjxy3qa.fsf@Rainer.invalid>
On Wed, 18 Sep 2019 18:21:49 +0200
Achim Gratz wrote:
> Takashi Yano writes:
> > - The commit fca4cda7a420d7b15ac217d008527e029d05758e broke Win7
> > compatibility. This patch fixes the issue.
> > ---
> > winsup/cygwin/fhandler_console.cc | 10 +++++-----
> > winsup/cygwin/select.cc | 2 +-
> > 2 files changed, 6 insertions(+), 6 deletions(-)
>
> It seems like an attractor for future bugs to define the same constant
> in two different places. Would there be a header that could provide the
> definition instead?
I agree with you. I will post revised one as v2.
--
Takashi Yano <takashi.yano@nifty.ne.jp>