This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 0/1] Cygwin: pty: Fix the behaviour of Ctrl-C in the pseudo console mode.


Hi Ken,

I appreciate checking the patch.

On Fri, 6 Sep 2019 17:59:02 +0000
Ken Brown wrote:
> I had several problems after applying this patch.
> 
> 1. I noticed some display glitches when building cygwin (with -j13 if that's 
> relevant).  For example, there were some unexpected blank lines and indented lines.
> 
> 2. At one point the build wouldn't complete at all.  It hung and had to be 
> killed with Ctrl-C.

I could not reproduce these with 32-bit cygwin (which I usually use),
however, I noticed that they happen with 64-bit cygwin. I apologize
for the lack of enough test.

I will post fixed version as v4 patch.

> 3. I used ssh from my normal account to log into an administrator account.  I 
> ran a script that produced a lot of output and piped it to less.  I pressed 'q' 
> after the first screen was displayed, and the displayed text didn't get cleared.

Are you using non-cygwin program in the script? If so, this may happen
in test release 3.1.0-0.4 as well.

> P.S. I'm leaving tomorrow for a short vacation, so I might not have time to 
> review any more patches until I return in about a week.

I see. So I have at least a week for consideration. :)

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]