This is the mail archive of the cygwin-patches mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Sep 4 21:49, Takashi Yano wrote: > On Wed, 4 Sep 2019 12:47:38 +0200 > Corinna Vinschen wrote: > > Why do you check the TERMs again here? After all, need_clear_screen > > is only true if one of these terms are used. > > Because, emacs seems to set environment TERM after fixup_after_exec() > is called. At the first check, TERM has the value of the terminal > in which emacs is executed. The first check is just in case. I still don't get it. The code in fixup_after_attach() is the only code snippet setting need_clear_screen = true. And that code also requires term != "dump" && term == "*emacs*" to set need_clear_screen. The code in reset_switch_to_pcon() requires that the need_clear_screen flag is true regardless of checking TERM. So this code depends on the successful TERM check from fixup_after_attach anyway. What am I missing? While at it, in fixup_after_attach(): + if (get_ttyp ()->num_pcon_attached_slaves == 0 && + term && strcmp (term, "dumb") && + term && !strstr (term, "emacs") && + !ALWAYS_USE_PCON) You're checking term for != NULL twice. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer
Attachment:
signature.asc
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |