This is the mail archive of the cygwin-patches mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Takashi, On Sep 4 10:44, Takashi Yano wrote: > - API hook used for pseudo console support causes slow down. > This patch limits API hook to only program which is linked > with the corresponding APIs. Normal cygwin program is not > linked with such APIs (such as WriteFile, etc...) directly, > therefore, no slow down occurs. However, console access by > cygwin.dll itself cannot switch the r/w pipe to pseudo console > side. Therefore, the code to switch it forcely to pseudo > console side is added to smallprint.cc and strace.cc. I'll push the other 3 patches from this series. For this patch, I wonder why you create set_ishybrid_and_switch_to_pcon while at the same time define a macro CHK_CONSOLE_ACCESS with identical functionality. Suggestion: Only define set_ishybrid_and_switch_to_pcon() as inline function (probably in winsup.h) and use only this througout. Thanks, Corinna -- Corinna Vinschen Cygwin Maintainer
Attachment:
signature.asc
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |