This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
[PATCH 1/1] Cygwin: console: Fix deadlock at calling fork().
- From: Takashi Yano <takashi dot yano at nifty dot ne dot jp>
- To: cygwin-patches at cygwin dot com
- Cc: Takashi Yano <takashi dot yano at nifty dot ne dot jp>
- Date: Mon, 12 Aug 2019 22:46:23 +0900
- Subject: [PATCH 1/1] Cygwin: console: Fix deadlock at calling fork().
- Dkim-filter: OpenDKIM Filter v2.10.3 conuserg-03.nifty.com x7CDkP1O012869
- References: <20190812134623.2102-1-takashi.yano@nifty.ne.jp>
- Calling fork() on console occasionally falls into deadlock. The reason
is not clear, however, this patch fixes this problem anyway.
---
winsup/cygwin/fhandler_console.cc | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index 3d26a0b90..4afb7efb7 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -168,8 +168,12 @@ fhandler_console::set_unit ()
if (created)
con.owner = getpid ();
}
- if (!created && shared_console_info && kill (con.owner, 0) == -1)
- con.owner = getpid ();
+ if (!created && shared_console_info)
+ {
+ pinfo p (con.owner);
+ if (!p)
+ con.owner = getpid ();
+ }
dev ().parse (devset);
if (devset != FH_ERROR)
--
2.21.0