This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH v2 0/2] silent fork retry with shm (broke emacs-X11)
- From: Ken Brown <kbrown at cornell dot edu>
- To: "cygwin-patches at cygwin dot com" <cygwin-patches at cygwin dot com>
- Date: Wed, 31 Jul 2019 17:25:20 +0000
- Subject: Re: [PATCH v2 0/2] silent fork retry with shm (broke emacs-X11)
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=cornell.edu;dmarc=pass action=none header.from=cornell.edu;dkim=pass header.d=cornell.edu;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iqps25TN4514W+DWPQZ/ByPPXm936aav0dSRUzapgbE=; b=gKoOpl63aew1gdf3AiQqy/pJ2vKd9cMBAP7fXtfC9zcXTYCBpZLP5BAkvu39fxfl/Mqs4pdFtp1rtKRHTSvxx4rimEDAejEatbr91T1V5ny90rYIozfcy/ZlfzDki8oM/1VNeVbd8YZn1fAIuuDAiXark+vf8zje0uVx5qmGkfb2y7zTr2BeNjAonQ7bYgB4G9Q3YszIBvjbp1rBaLdDUzy4fa9z1otHOoQ8SAF1KzewhIMm1Gx/ZVw0nZEoJyU7+pP9y+3tgMvNe45pTaBeOYY3JCGUAAIRC6V+VCfTdLfWfX46D0RcOeacf2A3ulXpCVt3Z57qFzjcDxUsWoaLcw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dvkkYCpEUIUDU//P0KUgiqBbhncyjNmEQe6f5UkYllORj1ZgrtZXevksgOMypDqnEvRNq1EQY+DaYbTEKLTK6k3p6JFfYjUfogeRaaWPn/BR0tZ067/IGAoBYIFwBN2lCS716VsbOqJTcSrfAHEx/E3EdIlO0VlxcCBg+0omujtcWfUGi3qVLVVqvGdTt69HyEWNMxrDs7IzKm8iTCdL5D2tsq4qhbPNuWR8DzVu0VqfkC7RF+G8ZdRiJldazNdhzuoKWv9Ubnj87E8VxLsDTLu4iJXjpXOCIeRA/IFJ57YdF32CC7GCQNanqLanMMJkEymLEAp9lnflzXjZwjie4g==
- References: <20190730160754.GZ11632@calimero.vinschen.de> <20190731103531.559-1-michael.haubenwallner@ssi-schaefer.com> <20190731165913.GB11632@calimero.vinschen.de>
On 7/31/2019 12:59 PM, Corinna Vinschen wrote:
> On Jul 31 12:35, Michael Haubenwallner wrote:
>> Hi Corinna,
>>
>> On 7/30/19 6:07 PM, Corinna Vinschen wrote:
>>> Hi Michael,
>>>
>>> On Jul 30 17:22, Michael Haubenwallner wrote:
>>>> Hi,
>>>>
>>>> following up
>>>> https://cygwin.com/ml/cygwin-patches/2019-q2/msg00155.html
>>>>
>>>> It turns out that fixup_shms_after_fork does require the child pinfo to
>>>> be "remember"ed, while the fork retry to be silent on failure requires
>>>> the child to not be "attach"ed yet.
>>>>
>>>> As current pinfo.remember performs both "remember" and "attach" at once,
>>>> the first patch does introduce pinfo.remember_without_attach, to not
>>>> change current behaviour of pinfo.remember and keep patches small.
>>>>
>>>> However, my first thought was to clean up pinfo API a little and have
>>>> remember not do both "remember+attach" at once, but introduce some new
>>>> remember_and_attach method instead. But then, when 'bool detach' is
>>>> true, the "_and_attach" does feel wrong.
>>>
>>> I'd prefer to drop the reattach call from remember, calling both of them
>>> where appropriate.
>>>
>>
>> Fine with me, even if that looks a little more complicated for spawn.
>
> Pushed, with just a small formatting tweak.
I can confirm that this fixes the problem I reported in
https://cygwin.com/ml/cygwin-patches/2019-q2/msg00155.html.
Ken