This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Cygwin: make path_conv::isdevice() return false on socket files
- From: Ken Brown <kbrown at cornell dot edu>
- To: "cygwin-patches at cygwin dot com" <cygwin-patches at cygwin dot com>
- Date: Sun, 21 Jul 2019 01:46:11 +0000
- Subject: Re: [PATCH] Cygwin: make path_conv::isdevice() return false on socket files
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=cornell.edu;dmarc=pass action=none header.from=cornell.edu;dkim=pass header.d=cornell.edu;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iRcYYioW+Z8zeDaOpJfqqUT71yRukZCIuZcz7NyxJXA=; b=nI97ha39isiYzCLiMRRaP0Nnr985JcOZYiucYi4gy8kEaNX0imkCvyMPbn3ml/8PUgFZIkg5UiAwy43kRJ9BzhdNPb9Xg+fSihJ7PHqxAuyyTLKOyGiFMdIQI/MvDsgMP2bKoOnkaWDtOQP0rPvvu8V43DrZIk8QxBHj4lJtyLqw3U8vRB/xxkbmGOWP4jnER8grjSedEuGZ48eHDI/9WEfdg3mTEEJfcu/zfwRI3xNeab0AJdjJrXnOpL58I6r+y8uz1F2n9Cjv3zNUCPWNY8LTmDPKbfljZRs2b4iY8uquV/b6nwaIEup1J/n+m5JmmSCeJuHghCU9AfqFTi0WLg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tep9D3Iitpw+7v6N56BViI1cgE+k6lZMTxNDLtn3p3qhoxToYwRZgqlNhG6SSEZx84IhNEVo5vrsiWZpaUSCDRiC33Y+EXkgeZ8TBKzbk+6JhzdChs07BXFV7GMCHJQBaGzd2eELUDrMuNq4lGPneU9QtUi5SgbHfcR+2kte/6n3DNt6uZjLGPR4KfcsRWDjlRdxFvHeXDr0fOq4lrxKXlnWM6JgyCzQVNs9uOA1REl3FHSpUPCx9yiMEEWUryfPiTCSixWQsLKiX0tT+oAYzbBH/Bm5vxyy87J65X6WHRj4V6MVl9oGOkx/FBdJmXXCknmZpFrEwILuv7TIcCKjCg==
- References: <20190718200026.1377-1-kbrown@cornell.edu> <20190719082845.GO3772@calimero.vinschen.de> <8dce0946-6f7e-a3f4-62b1-98cdbbe277ef@cornell.edu>
On 7/20/2019 6:53 PM, Ken Brown wrote:
> On 7/19/2019 4:28 AM, Corinna Vinschen wrote:
>> I see what you're doing here, but it's totally non-obvious from the
>> commit message why this fixes the problem and doesn't introduce weird
>> side-effects.
>
> Thanks. I was pretty careless with this patch. There's a new patch series on
> the way that (I hope) does it right.
>
>> An editorial note: While looking into your patch it occured to me that
>> it would be about time to go over all the is***device() methods and
>> clean up the mess. E.g., is_fs_device() is used by is_lnk_special()
>> only, is_auto_device() doesn't have much meaning,
>
> I've removed is_fs_device() and is_auto_device()
>
>> some funcs have
>> underscores, some don't.
>
> The convention seems to be that is<something> uses underscores if and only if
> "something" is a single word.
^
not
> The only exception I saw is isctty_capable. I
> didn't bother changing this, but I could if you want me to.
>
> Ken
>