This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
[PATCH 2/5] Cygwin: avoid GCC 8.3 errors with -Werror=stringop-truncation
- From: Ken Brown <kbrown at cornell dot edu>
- To: "cygwin-patches at cygwin dot com" <cygwin-patches at cygwin dot com>
- Date: Tue, 16 Jul 2019 17:34:24 +0000
- Subject: [PATCH 2/5] Cygwin: avoid GCC 8.3 errors with -Werror=stringop-truncation
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=cornell.edu;dmarc=pass action=none header.from=cornell.edu;dkim=pass header.d=cornell.edu;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i0zX8aHsmW5yXYyFuvpTfhLMD5LuFUUdCVOl3Gfi2pg=; b=mUWThgAkQtaB1FxOuSaZhtE8XsKVFI6a1ssM2qLci7YcI0KcvOTwWj9wKpY60oOYMk8l36/j1YwWq2Qa9AitYYGmI6XEmjUp97DxJKVOW0k/SQaAPbaSdnqq0s6WK/ONcGTckmp5/6Urxy4/Z8ysayVkl+Hg8xNkE3rsTbSSjAm9ZqFC3w6IG+PdoR+FxZbEyQ0VpYT4NKBrFN4hBUn31LT0n4qYR4PVU5ehSPVMd5coc4XU7R82jt2vUd/QlbGxYSu0VS09OfS79b76m0UjsrtF2/5dWRywTimas4LTiF2GF/kMYzj80lYUNNebP+wrDpLU2lcDLuniWAXB5hN2nw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PqVWOgeOQpXzVDcyPRnlHZu7oDvRp5yo0hurHDSn5L6+PQ+aQQwoEiFUo4PI65Z6fH4DKuNCJgixvLPVjjnuBj8HZPxOaUKuCXmlrqs4ZU9d0CDHTdijOwYCHBLQAH3RX+PmmIfG5pHFdJyPGCmesbV8Q8F/60+Ub2oPBxMvAeqV70Sxp+JfgMD29CdIf3bWMu8vzgecCuWZ4pEerFTmoi0vjtlRMaPct+ZgBrLCSe6S5LX7tiN/Y/okMQ6J5iZgonzbJWmU+x/dfVypWpeM9EbcZQLRAM6B/J3yZLiLHsdpPIgS3b6V0uJ1fopixxZLQ1SScjnf0yIV1chHiVKpDA==
- References: <20190716173407.17040-1-kbrown@cornell.edu>
---
winsup/cygwin/environ.cc | 2 +-
winsup/cygwin/include/sys/utmp.h | 6 +++---
winsup/cygwin/uname.cc | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/winsup/cygwin/environ.cc b/winsup/cygwin/environ.cc
index a47ed72e7..124842734 100644
--- a/winsup/cygwin/environ.cc
+++ b/winsup/cygwin/environ.cc
@@ -644,7 +644,7 @@ _addenv (const char *name, const char *value, int overwrite)
return -1; /* Oops. No more memory. */
/* Put name '=' value into current slot. */
- strncpy (envhere, name, namelen);
+ memcpy (envhere, name, namelen);
envhere[namelen] = '=';
strcpy (envhere + namelen + 1, value);
}
diff --git a/winsup/cygwin/include/sys/utmp.h b/winsup/cygwin/include/sys/utmp.h
index d90517cdd..acf804ad0 100644
--- a/winsup/cygwin/include/sys/utmp.h
+++ b/winsup/cygwin/include/sys/utmp.h
@@ -24,11 +24,11 @@ struct utmp
{
short ut_type;
pid_t ut_pid;
- char ut_line[UT_LINESIZE];
+ char ut_line[UT_LINESIZE] __attribute__ ((nonstring));
char ut_id[UT_IDLEN];
time_t ut_time;
- char ut_user[UT_NAMESIZE];
- char ut_host[UT_HOSTSIZE];
+ char ut_user[UT_NAMESIZE] __attribute__ ((nonstring));
+ char ut_host[UT_HOSTSIZE] __attribute__ ((nonstring));
long ut_addr;
};
diff --git a/winsup/cygwin/uname.cc b/winsup/cygwin/uname.cc
index 306cdee4a..e323335b4 100644
--- a/winsup/cygwin/uname.cc
+++ b/winsup/cygwin/uname.cc
@@ -25,7 +25,7 @@ uname_x (struct utsname *name)
{
__try
{
- char buf[NI_MAXHOST + 1];
+ char buf[NI_MAXHOST + 1] __attribute__ ((nonstring));
char *snp = strstr (cygwin_version.dll_build_date, "SNP");
memset (name, 0, sizeof (*name));
--
2.21.0