This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Cygwin: timerfd: avoid a deadlock


On Jun 25 14:25, Ken Brown wrote:
> Add a function timerfd_tracker::enter_critical_section_cancelable,
> which is like enter_critical_section but honors a cancel event.  Call
> this when a timer expires while the timerfd thread is in its inner
> loop.  This avoids a deadlock if timerfd_tracker::dtor has entered its
> critical section and is trying to cancel the thread.  See
> http://www.cygwin.org/ml/cygwin/2019-06/msg00096.html.
> ---
>  winsup/cygwin/timerfd.cc | 24 +++++++++++++++++++++++-
>  winsup/cygwin/timerfd.h  |  2 ++
>  2 files changed, 25 insertions(+), 1 deletion(-)

LGTM.  Please push.  Can you add a bugfix release msg to release/3.10,
please?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]