Re: [PATCH 2/2] Cygwin: fork: Remember child not before success.

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

Hi Michael,

On Apr 30 09:09, Michael Haubenwallner wrote:
> Do not remember the child before it was successfully initialized, or we
> would need more sophisticated cleanup on child initialization failure,
> like cleaning up the process table and suppressing SIGCHILD delivery
> with multiple threads ("waitproc") involved.
> ---
>  winsup/cygwin/fork.cc | 33 ++++++++++++++++++---------------
>  1 file changed, 18 insertions(+), 15 deletions(-)
> [...]
> +  yield (); /* For child.remember (), to perform async thread startup. */

Is that really necessary?  What's that fixing and what effect does this
have on the performance of the already very slow fork()?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

Attachment: signature.asc
Description: PGP signature