This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH 0/3] Updated patches for /proc/<pid>/environ
On Tue, Jan 10, 2017 at 4:41 PM, Corinna Vinschen
<corinna-cygwin@cygwin.com> wrote:
> On Jan 10 16:02, Erik Bray wrote:
>> From: "Erik M. Bray" <erik.bray@lri.fr>
>>
>> Updated versions of the patch set originally submitted at
>> https://cygwin.com/ml/cygwin-patches/2017-q1/msg00000.html
>>
>> I think all the indentation/whitespace/braces are cleaned up and consistent.
>>
>> I've also made sure that /proc/self/environ works now.
>>
>> All new code in these patches is licensed under the 2-clause BSD:
>> [...]
>
> You don't have to repeat that for any later patch you'd like to propose,
> I added you to the CONTRIBUTORS file now. Thank you!
Great!
>> ===============================================================================
>>
>> Erik M. Bray (3):
>> Move the core environment parsing of environ_init into a new
>> win32env_to_cygenv function.
>> Add a _pinfo.environ() method analogous to _pinfo.cmdline(), and
>> others.
>> Add a /proc/<pid>/environ proc file handler, analogous to
>> /proc/<pid>/cmdline.
>>
>> winsup/cygwin/environ.cc | 84 +++++++++++++++++++++++----------------
>> winsup/cygwin/environ.h | 2 +
>> winsup/cygwin/fhandler_process.cc | 22 ++++++++++
>> winsup/cygwin/pinfo.cc | 83 +++++++++++++++++++++++++++++++++++++-
>> winsup/cygwin/pinfo.h | 4 +-
>> 5 files changed, 157 insertions(+), 38 deletions(-)
>
> Patchset applied. The formatting in pinfo.cc was still not entirely
> correct, but I tweaked it manually. Please have a look into commit
> 171046d.
Ah, I see now. I think what happened is that in my vim it *does* look
properly aligned, but I haven't changed my settings the way you
suggested yet. Part of the problem is still the mixing of tabs and
spaces (even within that function), and I have ts=4, sw=4 so to me it
looked aligned.
Thanks for fixing it, and for accepting the patches!
Erik