This is the mail archive of the cygwin-patches mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] suggestion for faster pseudo-reloc.

Hi Jin-woo,

On Aug 26 10:59, Jin-woo Ye wrote:
> This patch fixes the problem making pseudo-reloc too slow when there
> is many pseudo-reloc entries in rdata section by deciding when not
> to call Virtual{Query,Protect} to save overhead.
> I tested this patch and time taken for pseudo-reloc reduced 1800ms
> to 16ms for 3682 entries.
> Please review this patch.

Done.  The idea is good, but I wasn't quite happy with your code.  It's
hard to read and it's more complicated than necessary.  For instance,
you only handle one page at a time, but your code keeps an array for two
page information entries around for no good reason.

I checked in a simplified version of your patch.  Please have a look.
Since the code in question is in the public domain, it doesn't require
a Cygwin copyright assignment.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]