This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] <asm/byteorder.h> missing prototypes warning
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Fri, 3 Apr 2009 10:26:35 +0200
- Subject: Re: [PATCH] <asm/byteorder.h> missing prototypes warning
- References: <49D57E45.4000409@users.sourceforge.net>
- Reply-to: cygwin-patches at cygwin dot com
On Apr 2 22:11, Yaakov S wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> This is similar in concept to the <stdio.h> patch I just posted to
> newlib@. It looks like I mistakenly removed the prototypes when I was
> trying to fix the C99 inline issue in <asm/byteorder.h>.
>
> Since this makes four lines which need the C99 inline workaround, I
> decided to make a macro similar to that in <stdio.h>. I didn't use the
> same macro name, since I didn't want to deal with a possible collision
> with, or dependency on, <stdio.h>. Perhaps there is a better way of
> dealing with this; I'm certainly open to ideas.
>
> Patch attached.
Wouldn't it be better to move newlib's _ELIDABLE_INLINE definition to
some nicely matchin header like _ansi.h and then use it wherever it
fits?
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat