This is the mail archive of the
mailing list for the Cygwin project.
On Tue, May 23, 2006 at 10:23:38PM -0400, Lev Bishop wrote:
>On 5/23/06, Lev Bishop wrote:
>>It does make sense. Try this version.
>Sorry, no. I'm stupid - ignore that version. There's not much point in
>doing assert(len>=0) given that len is unsigned, it's pretty much a
>given :-) How about just removing the assert()?
>So here's the 3rd attempt.
>2006-05-23 Lev Bishop <email@example.com>
> * fhandler.cc (readv): Deal with tot not precalculated.
>RCS file: /cvs/src/src/winsup/cygwin/fhandler.cc,v
>retrieving revision 1.251
>diff -u -p -r1.251 fhandler.cc
>--- fhandler.cc 22 Mar 2006 16:42:44 -0000 1.251
>+++ fhandler.cc 24 May 2006 02:22:10 -0000
>@@ -966,8 +966,6 @@ fhandler_base::readv (const struct iovec
> while (iovptr != iov);
>- assert (tot >= 0);
> if (!len)
> return 0;
I've checked this in but I changed the ChangeLog to:
2006-05-23 Lev Bishop <firstname.lastname@example.org>
* fhandler.cc (readv): Remove nonsensical assert.