This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Patch for silent crash with Cygwin1.dll v 1.5.19-4


Hi,
 
Since installing Cygwin1.dll v 1.5.19-4, I have a
problem with the computer algebra system SAGE dying at
startup with no error messages (i.e. I get returned to
the bash prompt with no messages of any sort).
I tracked the problem down to
verifyable_object_isvalid() in winsup/thread.cc. The
added the check below corrects this problem:

CHANGELOG:
2006-03-02 Gary Zablackis gzabl@yahoo.com
 * thread.cc (verifyable_object_isvalid): check for
NULL object or reference

CVS DIFF FILE:
Index: cygwin/thread.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/thread.cc,v
retrieving revision 1.196
diff -u -p -r1.196 thread.cc
--- cygwin/thread.cc    6 Feb 2006 18:24:06 -0000     
 1.196
+++ cygwin/thread.cc    2 Mar 2006 18:06:50 -0000
@@ -122,6 +122,9 @@ verifyable_object_isvalid (void
const *
   if (efault.faulted ())
     return INVALID_OBJECT;

+  if(!object || !*object)
+     return INVALID_OBJECT;
+
   if ((static_ptr1 && *object == static_ptr1) ||
       (static_ptr2 && *object == static_ptr2) ||
       (static_ptr3 && *object == static_ptr3))



__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]