This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] several new features for cygrunsrv


Brian Dessent wrote:

> -controlsToString(DWORD controls)
> +  char *base, *end;
> +  static char buf[34];
> +  int used = 0, dsiz = strlen (delim);

Crap, that is a mistake.  buf[34] should be something more generous like
128 or 256.  I had it set small to test to make sure it couldn't
overflow and forgot to put it back.

Brian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]