Re: [Patch]: mkdir -p and network drives

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

Hi Pierre,

On May 18 08:22, Pierre A. Humblet wrote:
> Here is the implementation of mkdir and rmdir with fhandlers.

Thanks for the patch.  Chris is going to reply later today, but I have
some questions beforehand.

> +_off64_t
> +fhandler_disk_file::telldir (DIR *dir)
> +{
> +  return dir->__d_position;
> +}
> +
>  DIR *
>  fhandler_disk_file::opendir ()
>  {
> @@ -1268,12 +1376,6 @@ fhandler_disk_file::readdir (DIR *dir)
>    return res;
>  }
> 
> -_off64_t
> -fhandler_disk_file::telldir (DIR *dir)
> -{
> -  return dir->__d_position;
> -}
> -

I don't see a reason why you moved telldir just a few lines up.
Any reasoning, perhaps together with a ChangeLog entry?

> -_off64_t
> -fhandler_cygdrive::telldir (DIR *dir)
> -{
> -  return fhandler_disk_file::telldir (dir);
> -}
> -
>  void
>  fhandler_cygdrive::seekdir (DIR *dir, _off64_t loc)
>  {

Why did you remove fhandler_cygdrive::telldir but not
fhandler_cygdrive::seekdir?  Both are just calling their base class
variants.

> -  else if (isvirtual_dev (dev.devn) && fileattr == INVALID_FILE_ATTRIBUTES)
> -    {
> -      error = dev.devn == FH_NETDRIVE ? ENOSHARE : ENOENT;
> -      return;
> -    }

I don't understand this one.  What's the rational behind removing
these lines?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin@cygwin.com
Red Hat, Inc.