This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] gcc4 fixes


On Tue, May 17, 2005 at 03:50:08PM -0700, Brian Dessent wrote:
>
>This is just a trivial change of argument to execl() testcases, which
>supresses the warning 'missing sentinel in function call' in gcc4 that
>causes the tests to fail.
>
>winsup/testsuite
>2005-05-17  Brian Dessent  <brian@dessent.net>
>
>	* winsup.api/signal-into-win32-api.c (main): Use 'NULL' instead
>	of '0' in argument list to avoid compiler warning with gcc4.
>	* winsup.api/ltp/execle01.c (main): Ditto.
>	* winsup.api/ltp/execlp01.c (main): Ditto.
>	* winsup.api/ltp/fcntl07.c (do_exec): Ditto.
>	* winsup.api/ltp/fcntl07B.c (do_exec): Ditto.

Go ahead and check these in but please use GNU formatting conventions,
i.e., it's (char *) NULL, not (char *)NULL.  Actually, isn't just NULL
sufficient?

>This fixes the problem of mmap() not working with gcc4.
>
>winsup/cygwin
>2005-05-17  Brian Dessent  <brian@dessent.net>
>
>	* mmap.cc (mmap64): Move 'granularity' into file scope so that
>	it will be initialized.

Sorry but no.  This is a workaround.  We need to fix the actual problem.

Thanks.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]