Re: [Patch]: mkdir -p and network drives

[Christopher Faylor <cgf-no-personal-reply-please at cygwin dot com>]

On Thu, May 12, 2005 at 04:02:22PM -0400, Christopher Faylor wrote:
>On Thu, May 12, 2005 at 03:49:21PM -0400, Pierre A. Humblet wrote:
>>----- Original Message ----- 
>>From: "Corinna Vinschen" <corinna-cygwin@cygwin.com>
>>To: <cygwin-patches@cygwin.com>
>>Sent: Wednesday, May 11, 2005 4:53 AM
>>Subject: Re: [Patch]: mkdir -p and network drives
>>
>>
>>> I don't like the idea of isrofs being an inline function in dir.cc.
>>> Wouldn't that be better a method in path_conv?  It would be helpful
>>> for other functions, too.  For instance, unlink and symlink_worker.
>>> In the (not so) long run we should really move all of these functions
>>> into the fhandlers, though.
>>
>>After looking into it, moving mkdir and rmdir to fhandlers should be
>>quite simple. I will do that early next week.
>
>In the meantime, I'm going to follow through on Corinna's suggestion.
>Moving this into path.cc would mean that we could eventually add a "-r"
>option to mount which would be a nice thing.
>
>I'm getting ready to roll out a 1.5.17 so I'll get something with EROFS
>functionality into that.

I added read-only filesystem checking to path_conv::check so the latest
snapshot seems to work fine with the latest coreutils (trixie is a
system in my home network which exports shares):

  bash-2.05b$ mkdir -p //trixie/share/tmp/foo/bar
  bash-2.05b$ ls -ld //trixie/share/tmp/foo/bar
  drwxr-xr-x  1 cgf None 0 May 13 09:47 //trixie/share/tmp/foo/bar
  bash-2.05b$ mkdir -p //trixie/blaz
  mkdir: cannot create directory `//trixie/blaz': Read-only file system
  bash-2.05b$ rmdir //trixie/share
  rmdir: `//trixie/share': Directory not empty
  bash-2.05b$ rmdir //trixie
  rmdir: `//trixie': Read-only file system

  bash-2.05b$ rmdir //
  rmdir: `//': Read-only file system

  bash-2.05b$ mkdir -p //foo/bar/blaz
  mkdir: cannot create directory `//foo': No such host or network path
  bash-2.05b$ rmdir //foo/bar
  rmdir: `//foo/bar': No such host or network path
  bash-2.05b$ rmdir //foo
  rmdir: `//foo': No such host or network path

The support for read-only filesystems should be the same as in Pierre's
patch, i.e., it is not comprehensive enough to be considered a full-fledged
useful feature but it does seem to solve the mkdir -p problem.

The "rmdir //" should really say "directory not empty" but that's a fix
for another day.

cgf