This is the mail archive of the
mailing list for the Cygwin project.
Re: [PATCH]: Still stripping
- From: Christopher Faylor <cgf-no-personal-reply-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Thu, 23 Dec 2004 14:34:05 -0500
- Subject: Re: [PATCH]: Still stripping
- References: <41CAF567.365C09F7@phumblet.no-ip.org>
- Reply-to: cygwin-patches at cygwin dot com
On Thu, Dec 23, 2004 at 11:42:15AM -0500, Pierre A. Humblet wrote:
>In a case such as "abc..exe", the posix_path "abc." should not be
>stripped. The patch below only strips the posix path if the win32
>path was stripped. I don't think that the posix path can be empty
>in that case.
>2004-12-23 Pierre Humblet <email@example.com>
> * path.h (path_conv::set_normalized_path): Add second argument.
> * path.cc (path_conv::check): Declare, set and use "strip_tail".
> (path_conv::set_normalized_path): Add and use second argument,
> replacing all tail stripping tests.
I'm not sure that your assumption of dot stripping is true in the first
case of set_normalized_path in build_fh_dev in dtable.cc. I do like the
idea of letting the previously derived path_conv tail stripping test
control whether set_normalized_path does stripping or not, though.
I have grown to dislike default parameters in c++. I'm not sure why because
I used to think they were pretty nifty. So, I'll check in your patch minus
the default and keeping the original while loop in set_normalized_path
more or less intact.