This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to allow trailing dots on managed mounts

cgf wrote:

> Is it correct to assume that only fhandler_base::open cares about
>trailing dots?

Good point. This bring back memories.

The initial motivation was to fix problems introduced by the 
use of NtCreateFile
and there were successive changes

2004-04-30  Corinna Vinschen  <>

        * (normalize_posix_path): Remove trailing dots and spaces.

2004-05-06  Pierre Humblet <>

        * (path_conv::check): Strip trailing dots and spaces and
        return error if the final component had only dots and spaces.
        (normalize_posix_path): Revert 2004-04-30.

However, as a side effect, checking the tail in :check
also cleanly fixed longstanding dormant issues with the path hash
and with chroot (at least).

So checking the tail in fhandler_base::open() is too late.
It should be done before exiting  :check(), perhaps only in the
case where the path refers to a disk file, preferably
with little processing overhead.

Although it wasn't done before 2004/04, we should also make sure
(I have no free time for the moment) that nothing goes wrong 
inside :check() while we lookup symbolic links.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]