This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to allow trailing dots on managed mounts

On Thu, Dec 16, 2004 at 04:53:39PM +0100, Corinna Vinschen wrote:
>On Dec 16 10:00, Christopher Faylor wrote:
>> On Thu, Dec 16, 2004 at 09:55:48AM -0500, Pierre A. Humblet wrote:
>> >Here is an untested patch.
>> >I hope Mark can test it (on managed and unmanaged mounts,
>> >including basenames consisting entirely of dots and spaces)
>> >and possibly make adjustments, without having to file the 
>> >paperwork.
>> >
>> >Pierre
>> >
>> >	* (path_conv::check): Do not strip trailing dots and spaces.
>> >	* (fhandler_base::open): Strip trailing dots and spaces.
>> Is it correct to assume that only fhandler_base::open cares about
>> trailing dots?
>So far, yes.  But somehow moving this code into open() looks a bit like
>a step backwards to me.  The general direction is to do more stuff using
>NT functions, isn't it?  So in the long run we would get the same problem
>in other code paths as well.

That was my thought as well.

>Since the mount code is called from path_conv anyway, wouldn't it be
>better to pass the information "managed mount or not" up to path_conv?

How about just doing the pathname munging in `conv_to_win32_path' if/when
it's needed?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]