This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Here is a simple patch that simplifies chdir processing and avoids calling normalized_posix_path multiple times. If it doesn't break anything it will simplify removing trailing dots and spaces, as discussed earlier today. I have kept the test "pcheck_case == PCHECK_RELAXED", although I don't see why it helps. Also I have not edited the long comment on line 3329. I don't understand all the points it is trying to make. I think the patch does what the FIXME talks about, except that it's actually cheap. During tests I have seen that 'touch " "' touches the current directory. It's probably a good idea to disallow names consisting entirely of spaces, as we already disallow names consisting entirely of dots. Pierre 2004-05-05 Pierre Humblet <pierre.humblet@ieee.org> * path.cc (chdir): Do not check for trailing spaces. Specify PC_POSIX in constructing "path". Pass normalized_path to cygheap->cwd.set except when it starts with a drive. (cwdstuff::set): Assume posix_cwd is already normalized.
Attachment:
path.diff
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |