This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Checking integrity of installed packages in cygcheck

On Sat, 9 Aug 2003, Christopher Faylor wrote:

> On Sat, Aug 09, 2003 at 03:52:55PM -0400, Igor Pechtchanski wrote:
> >On Sat, 9 Aug 2003, Christopher Faylor wrote:
> >>On checking this patch a little further, I see that it gives a
> >>misleading "OK" when the package file is missing.  Could you detect
> >>that case?
> >
> >Yes.  The attached patch (against the initial one applied) does just
> >that.
> I've checked this in, too, with some changes.  The version of this file
> in CVS had my fix to convert slashes to backslashes so your patch didn't
> cleanly apply.  I also allocated a static buffer and only calculated the
> DOS pathname for gzip.exe once.  Finally, I changed all of the
> formatting to GNU-style.

Ugh, yes, I forgot to do a CVS update...  Sorry about that.  As for the
GNU-style formatting, that space between the function name and the paren
always trips me up...

Anyway, there were some bugs in the code that was checked in -- the
attached patch fixes them.

> Thanks for this increased functionality.  I used this to update my own
> installation.  It looks like I had somehow damaged my installation a
> while ago.  Some files were missing, some package lists were missing.
> Who knew?
> cgf

Glad it was useful.
2003-08-10  Igor Pechtchanski  <>

	* (check_package_files): Fix extra '/' in filename.
	Resize command buffer.  Fix buffer overflow bug.

      |\      _,,,---,,_
ZZZzz /,`.-'`'    -.  ;-;;,_
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton

Attachment: cygcheck-verify-packages-fix.patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]