This is the mail archive of the
mailing list for the Cygwin project.
Re: [PATCH] Checking integrity of installed packages in cygcheck
- From: Igor Pechtchanski <pechtcha at cs dot nyu dot edu>
- To: cygwin-patches at cygwin dot com
- Date: Sat, 9 Aug 2003 15:41:45 -0400 (EDT)
- Subject: Re: [PATCH] Checking integrity of installed packages in cygcheck
- Reply-to: cygwin-patches at cygwin dot com
On Sat, 9 Aug 2003, Christopher Faylor wrote:
> On Sat, Aug 09, 2003 at 12:12:11PM -0400, Christopher Faylor wrote:
> >On Thu, Aug 07, 2003 at 06:50:10PM -0400, Igor Pechtchanski wrote:
> >>This patch adds most of the capability of the script from
> >><http://cygwin.com/ml/cygwin-apps/2003-08/msg00106.html> to cygcheck.
> >>It is triggered by the "-c" flag to cygcheck. "Integrity" is a rather
> >>strong word, actually, as all this checks for is the existence of files
> >>and directories, but this could be further built upon (for example, tar
> >>has a diff option that could be useful). The patch is against cvs HEAD
> >>with my previous micropatch
> >>(<http://cygwin.com/ml/cygwin-patches/2003-q3/msg00058.html>) applied.
> >>Comments and suggestions welcome.
> >I'm getting some odd errors when I apply this patch:
> >"4NT: Unknown command f:"
> >(as you can see I use 4NT).
> >I haven't had time to debug where these are coming from but I get one
> >for every file displayed.
> The enclosed patch fixes that.
> I'll check this in but it would be nice if (WBNI) this used a mingw gzip
> library rather than calling gzip directly. That's a fair amount of
> work but I could resurrect the zlib library in winsup if necessary.
> I wonder why setup is using gzip rather than bzip2 for the package files...
> --- dump_setup.cc~ 2003-08-07 21:42:02.000000000 -0400
> +++ dump_setup.cc 2003-08-09 12:16:39.658996759 -0400
> @@ -242,6 +242,8 @@ check_package_files (int verbose, char *
> strcat(strcat(filelist, package), ".lst.gz");
> char *zcat = cygpath("/bin/gzip.exe", NULL);
> char command;
> + while (char *p = strchr (zcat, '/'))
> + *p = '\\';
> strcat(strcpy(command, zcat), filelist);
> FILE *fp = popen (command, "rt");
> char buf;
Oops, sorry, I should have added that I only tested that patch on Win2k...
As for the mingw zlib library, is it already a requirement for building
Cygwin? If not, I'd be very reluctant to make it one...
|\ _,,,---,,_ email@example.com
ZZZzz /,`.-'`' -. ;-;;,_ firstname.lastname@example.org
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster." -- Patrick Naughton