This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: More passwd/group patches

On Sun, Nov 24, 2002 at 11:28:17AM -0500, Pierre A. Humblet wrote:
> At 05:08 PM 11/24/2002 +0100, Corinna Vinschen wrote:
> >The appropriate changes to would collide with your patch
> >so I'd like to ask you if you want me to make the necessary changes
> >to comply with Solaris first and then to send a revised patch, or
> >if you want to incorporate these changes into your patch, too?
> Corinna,
> Between the two proposals I prefer the first (you make the change first).
> The don't like the second much, because there is a possibility of 
> misunderstanding.
> There is also a third possibility: apply the patch and then fix it to
> match solaris. That may minimize the overall amount of work and 
> reviewing.

I've checked everything in.

I'm getting slow debugging.  It took me an hour to find the problem here:

+  if (aclbufp) {
+    if (EqualSid (owner_sid, group_sid))
+      lacl[0].a_perm = lacl[1].a_perm;
+    aclsort (pos, 0, aclbufp);
+    if (pos > nentries)
+      pos = nentries;
     memcpy (aclbufp, lacl, pos * sizeof (__aclent16_t));
-  aclsort (pos, 0, aclbufp);
+  }

Do you see the problem?

Anyway, thanks for the patch,

Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                      
Red Hat, Inc.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]