This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ntsec patch #4: passwd and group

On Wed, Nov 20, 2002 at 11:29:08AM -0500, Pierre A. Humblet wrote:
> > How would you like to remove LookupAccountSidA?  Just remove it and
> > debug_printf ("Failed to get primary group name.") ?
> OK, the debug printf can be removed too, the result will be visible in the
> other debug_printf below.
> A more ambitious way is to see if the sid is local or not. If it is local we
> can safely call LookupAccountSidA.

I chose the less ambitious way for now.

> > Rewriting the external funcs and creating and using the internal funcs
> > is ok for another patch.
> Glad we talk! The external non multithread functions are already OK (i.e. POSIX), 
> as long as we have the new internal functions.
> In other words, if the internal functions don't reread the files, then there
> is no need for new static buffers. The existing buffers can only be wiped out
> on the next external call, which is OK.

You're correct, sure.  Somehow I was already fixed on the "static buffer

Applied with changes.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                      
Red Hat, Inc.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]