This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] pthread_fork Part 1


On Sat, 2002-08-17 at 06:18, Thomas Pfaff wrote:
> 
> Rob suggested to break the pthread_fork patch into smaller chunks. Ths is
> part 1 providing a fork save key value handling.
> The patch will add a linked list of keys to MTinterface and a fork buffer
> in pthread_key where the key values are passed between parent and child.

In general, I liked this patch.
I've made some essentially stylistic alterations, to make the resulting
code a little easier to read. I realise you followed my lead on some of
the layout - I need to fix up my existing code too :].

Here's a snapshot of HEAD with your patch after my changes.

I'd love it if you sent me the source for the test case you used when
developing this.

I'm really sorry that it's taken me so long to get back to reviewing
these.

Cheers,
Rob

Attachment: pthread_fork_part1_rob1.patch
Description: Text document

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]