This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]Reduce messages in setup.log

----- Original Message -----
From: "Robert Collins" <>
To: "Michael A Chase" <>; <>
Sent: Monday, January 28, 2002 21:38
Subject: Re: [PATCH]Reduce messages in setup.log

> ----- Original Message -----
> From: "Michael A Chase" <>
> > If the intention of those messages is to highlight methods that should
> have
> > been overridden but aren't, then setup.log is the right place.
> Essentially, yes thats why they are there: incomplete methods. When I
> review your patch I'll be looking at the function status.

There's no sense spending your time on the patch.  I need to change it
drastically or withdraw it.

If I understand the intent:

1.  If a method only returns a constant 0, the message should go to
setup.log.full to make it easier to tell where more work may be needed.

2.  If a method does more than just return a constant 0, it should not call
log(), or if it does, the message is only needed in setup.log.

Possible candidates:

   Performs actual work: compress_bz::peek(), compress_gz::peek(),
compress_gz::~compress_gz(), io_stream_cygfile::peek(), and

   Returns NULL: archive::next_file_name(), compress::next_file_name(), and

   Returns -1: compress_bz::seek() and compress_gz::seek().
Mac :})
** I normally forward private questions to the appropriate mail list. **
Ask Smarter:
Give a hobbit a fish and he eats fish for a day.
Give a hobbit a ring and he eats fish for an age.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]