This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: Problem with winsup/cinstall compilation

> On Sat, Jan 12, 2002 at 07:36:00PM +0100, Corinna Vinschen wrote:
> >On Sat, Jan 12, 2002 at 07:14:25PM +0100, Ralf Habacker wrote:
> >> EMail:
> >>>>I have looked in the cygwin ChangeLog for making a proper ChangeLog,
> >>>>but don't recognized this details.  Sorry
> >>>
> >>>
> >>>
> >>I have read this and I see many "what not to do statements" relating
> >>changelog.  I think it would be easier and faster to read if some true
> >>examples are included at this page.  :-)
> >
> >Isn't the ChangeLog file itself *the* example?
Yet, see above. But than it should be consequently used in the ChangeLogs.

from I found the following statement for example

Improper ChangeLog formatting:
	Multiple functions or filenames on a ChangeLog line (e.g., "*, Add argument
to baf call.")

I have found about 400 several changelog entrys lines in the whole cygwin src tree (including
winsup) with this error.
Relating to the total number of entries (1146) this means that over 30% of all changelog
entries are not conform with the style guide you've told about.

You can reproduce this benchmark with the following lines:

finding all violations:

 find src -name 'ChangeLog' -exec grep ",.*:" {} \; | grep -v "[()]" | wc -l

number of changelog entries:

 find src -name 'ChangeLog' -exec egrep "^[0-9]+-[0-9]+-" {} \;  | wc -l

In the winsup tree itself there are about 4 % of all entry only with this violation.

> Yes.  That and the *link to the GNU ChangeLog Standards*.
Yes, but the above result seems to me that more people as I have problems to know the correct

> And, regardless, I believe that Ralf's ChangeLog didn't even adhere to
> even the "what not to do statements".

Yes I've done a mistakes in spelling ("ditto.") and building full sentense "missing dot", but
I'm onot the only one.

"... full sentence" - examples missing dot at the end

2001-12-14  Christopher Faylor  <>
        * configure: Regenerate

2001-11-03  Christopher Faylor  <>
	* configure: Regenerate.

2000-09-02  Egor Duda  <>

	* Add new goal "check"

Thu May 25 18:39:24 2000  Christopher Faylor <>

	* configure: Regenerate

2000-04-17  DJ Delorie  <>

	* Makefile.common (srcdir): remove dependence on where pwd is

2000-01-26  DJ Delorie  <>

	* doc/ fix doctool -d options

So I don't want to accuse someone, but my objectives are to make it easier specific for new
contributors to follow this rules and again putting some examples direct on this contribution
page I think would shorten the learning curve.

After Robert Collins has wrote me, that there was something wrong with this ChangeLog, I have
looked more deeply what he is meaning and now I'm ready for this task.  (I hope I remember
all very detailed issues, when I add a patch in an half year)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]