This is the mail archive of the
mailing list for the Cygwin project.
RE: [PATCH] mkpasswd.c - allows selection of specific user
- From: Mark Bradshaw <bradshaw at staff dot crosswalk dot com>
- To: "'cygwin-patches at cygwin dot com'" <cygwin-patches at cygwin dot com>
- Date: Sat, 12 Jan 2002 07:32:39 -0500
- Subject: RE: [PATCH] mkpasswd.c - allows selection of specific user
> -----Original Message-----
> From: Christopher Faylor [mailto:firstname.lastname@example.org]
> Sent: Friday, January 11, 2002 10:19 PM
> To: email@example.com
> Subject: Re: [PATCH] mkpasswd.c - allows selection of specific user
> On Fri, Jan 11, 2002 at 08:59:47PM -0500, Mark Bradshaw wrote:
> > You probably don't remember this, but I had volunteered back in
> >December to make the error messages in mkpasswd a bit more user
> >friendly. Well, I finally took a few free moments to take a stab at
> >it. I sprinkled a liberal dose of FormatMessage wherever error
> >reporting was going on. So before, where there'd be a message that
> >basically said, "You got error number 12345", now it'll
> print out the
> >corresponding text.
> These are nice changes, but I have a few observations:
> 1) The ChangeLog needs work. See http://cygwin.com/contrib.html .
Bleh. It's always my Changelog. I seem to be Changelog challenged, but I
used exactly the same format that I used last time.
> 2) I don't think there is any reason to report the number if you
> are translating the text, so, I'd prefer:
> mkpasswd: The user name could not be found
> 3) Rather than sprinkle FormatMessage throughout the code, couldn't
> a single function be used instead. It looks like mkpasswd just
> needs some kind of generic error function which takes an argument
> indicating whether to translate the Windows error or not.
Ok. I'll do that.
> I look forward to getting these into cygwin. Translating the
> errors will reduce a lot of user confusion.
> Btw, do you have an assignment on file with Red Hat? I can't
> remember. If not, you'll need to send in an assignment as
> referenced in the above URL.
Yeah. I did one for the -u option of mkpasswd.