Re: known issues with current dll

[Egor Duda <deo at logos-m dot ru>]

Hi!

Sunday, 18 March, 2001 Christopher Faylor cgf@redhat.com wrote:

CF> On Sun, Mar 18, 2001 at 06:09:02PM +0300, Egor Duda wrote:
>>Saturday, 17 March, 2001 Christopher Faylor cgf@redhat.com wrote:
>>CF> On Sat, Mar 17, 2001 at 04:05:36PM +0300, Egor Duda wrote:
>>>>to  solve  ctrl-D  problem  i  see  2 ways -- either return to the old
>>>>scheme,  when  master  sends dummy buffer to slave via pipe on eof, or
>>>>tweak   ready_to_read  stuff  for fhandler_tty_slave, so it will react
>>>>when  input_available_event  is  signalled, not when pipe handle does.
>>>>currently, i'm trying to do the latter.
>>CF> I think that the latter makes sense.
>>
>>CF> Maybe it's time to separate the pipe stuff from the tty stuff in select.cc
>>
>>this  patch  fixes  ctrl-d  problem.  this  also  make  cygwin discard
>>contents of input buffer in canonical mode when user type VINTR, VSTOP
>>or VSUSP character.

CF> Looks perfect, with one comment:

CF> @@ -762,4 +762,6 @@ public:
         
CF>    off_t lseek (off_t, int) { return 0; }
CF> +  virtual select_record *select_read (select_record *s);
CF> +  int ready_for_read (int fd, DWORD howlong, int ignra);
CF>  };

CF> Is there any reason for this method to be virtual?

no. actually, 'virtual' here is ignored as this method was declared as
virtual in the base class. i'll remove 'virtual' here.

CF> Otherwise, please check this in.  It will be interesting to see if this
CF> fixes Earnie's problem.

Egor.            mailto:deo@logos-m.ru ICQ 5165414 FidoNet 2:5020/496.19