This is the mail archive of the
cygwin-developers@cygwin.com
mailing list for the Cygwin project.
Re: miscfuncs.cc won't compile with --enable-debugging
- To: cygwin-developers at cygwin dot com
- Subject: Re: miscfuncs.cc won't compile with --enable-debugging
- From: Christopher Faylor <cgf at redhat dot com>
- Date: Mon, 22 Oct 2001 17:21:23 -0400
- References: <20011022202804.5132.qmail@lizard.curl.com>
- Reply-To: cygwin-developers at cygwin dot com
On Mon, Oct 22, 2001 at 04:28:04PM -0400, Jonathan Kamens wrote:
>Corinna checked a change in today which break miscfuncs.cc when
>--enable-debugging is used. Here's a patch:
Thanks but I think that it makes sense for set_errno to always do the
same thing regardless of whether DEBUGGING is enabled. I checked in
a patch to do this.
cgf
>Index: miscfuncs.cc
>===================================================================
>RCS file: /cvs/src/src/winsup/cygwin/miscfuncs.cc,v
>retrieving revision 1.7
>diff -u -r1.7 miscfuncs.cc
>--- miscfuncs.cc 2001/10/22 11:31:39 1.7
>+++ miscfuncs.cc 2001/10/22 20:26:55
>@@ -158,7 +158,7 @@
> __check_invalid_read_ptr_errno (const void *s, unsigned sz)
> {
> if (!s || IsBadReadPtr ((void *) s, sz))
>- return set_errno (EFAULT);
>+ set_errno (EFAULT);
>
>- return 0;
>+ return get_errno();
> }