This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH setup 0/3] Fix "extrakeys" issues

On 28/11/2017 14:56, Ken Brown wrote:
The "extrakeys" user setting contains saved extra gpg keys.  It was
introduced in 2009 to replace the use of a file
/etc/setup/last-extrakeys.  It has apparently never worked right.
Here are the issues I've found:

  - User settings are read and written as NUL-terminated strings, but
    extra keys are terminated by LF instead.  On writing, this causes
    garbage to be written into setup.rc.  On reading, this causes the
    final saved key to be discarded.

  - The ExtraKeysSetting constructor calls count_keys() without setting
    bufsize to a positive value.  This causes *all* saved keys to be

  - Saved keys contain several '#' characters.  These are treated as
    comment characters in setup.rc, so that all keys are truncated when

  - There are still references to the "last-extrakeys" file in comments
    and in a help string.

This patch series attempts to fix all these problems.  In the case of
'#', the fix is to treat '#' as a comment character only if it's the
first non-whitespace character on a line.  I don't think this will
cause problems for any existing uses of '#', but I haven't done a
thorough check of this yet.

Comments in setup.rc seem to have very little value (since they will be destroyed the next time setup writes it)

Ken Brown (3):
   Fix the reading and writing of the "extrakeys" user setting
   Change the interpretation of '#' in setup.rc
   Remove references to "last-extrakeys"  | 9 ++++++++-
  KeysSetting.h   | 2 +- | 8 ++++----       | 8 ++++----
  4 files changed, 17 insertions(+), 10 deletions(-)

Great. Please apply.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]