This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] make setup mirror list more like web page not just urls

On 11/24/2017 4:47 PM, Brian Inglis wrote:
I am suggesting we split get_site_list to create the setup.rc cached list at the
start, flag entries false,

So you're throwing away the information that the entries in the cached site list came from mirrors.lst in a previous setup run?

merge the last-mirror entry into that,

The sites listed under "last-mirror" are those that were selected during the last setup run. They can include user-added URLs as well as mirrors from mirrors.lst. They shouldn't be merged into the cached site list.

checking the
url for a match to use the list entry instead of the last mirror entry, then
after the mirrors.lst download, compare the cached entries with the mirrors list
entries, checking the url for a match to use the current mirrors list entry
instead of the cached entry,

I'm not sure what you mean here. Are you proposing merging the cached site list into all_site_list along with the sites from the current mirrors.lst? I don't think that's a good idea. It would mean deliberately showing the user old mirrors that are no longer in mirrors.lst. Currently that only happens if such a mirror came from the "last-mirror" list, and it generates a warning when it happens.

which would be flagged true in the cached list, and
proceeding with the rest of get_site_list and then check_dropped_mirrors.

(Also noticed, the site list search and merge operations in registerSavedSite
and load_site_list could be refactored into a separate site_list::merge() member
function, by allowing for an optional exclusion site list.)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]