Re: [ITA] libXpm-noX 3.5.12

[Ken Brown <kbrown at cornell dot edu>]

On 11/20/2017 11:42 AM, Jon Turney wrote:
> On 15/11/2017 17:30, Ken Brown wrote:
> > My cygport file and other files needed for reproducing the build are 
> > attached.
>
> I added this to your uploads, but this fails to build for me:
>
> libXpm-nox/libXpm-noX-3.5.12-1.src/libXpm-noX-3.5.12-1.x86_6/src/libXpm-3.5.12/src/simx.c:42:40: 
> fatal error: xpmi.h: No such file or directory
>   #include "xpmi.h"   /* for XpmMalloc */
>
> which looks like some sort of case-sensitivity issue vs. XpmI.h, but I 
> can't see that it's introduced by your patches, and I don't understand 
> how it could be present in upstream...

Thanks for checking the build.  I didn't catch this because I did the 
build on a Cygwin installation that was case insensitive (which is not 
my usual habit).

The problem actually is present in upstream.  But it isn't a problem 
from the upstream point of view because the file simx.c is intended for 
the native Windows build, where case insensitivity can be assumed.

For the record, I'm attaching a revised 04-source-code.patch that fixes 
this.

Ken

Attachment: 04-source-code.patch
Description: Text document