On 01/11/2017 20:38, Ken Brown wrote:
If there is a download failure and the user clicks Yes in response
to "Download Incomplete. Try again?", then setup will crash. The
crash occurs at PickView.cc:447 because i->source() is NULL.
Thanks for finding all these problems!
I haven't yet analyzed this in further detail, but the crux of the
issue seems to be that we call do_ini_thread a second time without
having cleaned out the package database and the libsolv pool.
This is probably a symptom of a more general problem, which is that
we haven't thought carefully (or at least I haven't) about what
happens when we visit certain pages for a second time, after the
libsolv pool has been created.
The fact that this isn't considered at all at the moment makes me
wonder if it's working correctly in this situation currently. But,
yeah, I agree that packagedb state should be cleared in this case.
I tried with the attached, but it still segfaults at the same place.
This seems to be because all the packagedb prep (including
fixup_source_package_ids) is in OnInit() (which is only called once
per page, but lazily), rather than OnActivate(), so probably some
more restructuring is needed there :(